[POC] trim #1318
Draft
[POC] trim #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lplewa
reviewed
May 15, 2025
include/umf/pools/pool_disjoint.h
Outdated
| /// @param pool handle to the memory pool. | ||
| /// @param minSlabsToKeep minimum number of slabs to keep. | ||
| /// @return UMF_RESULT_SUCCESS on success or appropriate error code on failure. | ||
| umf_result_t umfDisjointPoolTrimMemory(void *pool, size_t minSlabsToKeep); |
vinser52
reviewed
May 15, 2025
include/umf/pools/pool_disjoint.h
Outdated
| /// @param pool handle to the memory pool. | ||
| /// @param minSlabsToKeep minimum number of slabs to keep. | ||
| /// @return UMF_RESULT_SUCCESS on success or appropriate error code on failure. | ||
| umf_result_t umfDisjointPoolTrimMemory(void *pool, size_t minSlabsToKeep); |
There was a problem hiding this comment.
How this API is going to be used? And why is it disjoint pool specific?
There was a problem hiding this comment.
Since we are trying to stabilize the API before the 1.0 release, we should review such changes at the UMF tech meeting first.
I mean draft PR is OK, but let’s discuss before merge
ldorau
requested changes
May 19, 2025
ldorau
approved these changes
May 19, 2025
bratpiorka
force-pushed
the
rrudnick_dp_trim
branch
from
6de8410 to
6a3ae03
Compare
bratpiorka
force-pushed
the
rrudnick_dp_trim
branch
3 times, most recently
from
4a3b48f to
4dee8a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
umfDisjointPoolTrimMemory needed for L0 POC